From 7e969fa682d2227478443e2f15bbfe7a2f512173 Mon Sep 17 00:00:00 2001 From: Takuma Date: Mon, 14 Jun 2021 23:05:46 +0900 Subject: [PATCH] Call subscribe_to_mailchimp_newsletter after the transaction is commited (#13969) * Call subscribe_to_mailchimp_newsletter by after_commit instead of after_save * s/save/commit --- app/models/user.rb | 2 +- spec/models/user_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index 301751b73..f26b36400 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -346,10 +346,10 @@ class User < ApplicationRecord # NOTE: @citizen428 Temporary while migrating to generalized profiles after_save { |user| user.profile&.save if user.profile&.changed? } - after_save :subscribe_to_mailchimp_newsletter after_create_commit :send_welcome_notification + after_commit :subscribe_to_mailchimp_newsletter after_commit :sync_users_settings_table, :sync_users_notification_settings_table, on: %i[create update] after_commit :bust_cache diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index af4f939cd..ea8d0d5bf 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -435,7 +435,7 @@ RSpec.describe User, type: :model do end end - context "when callbacks are triggered after save" do + context "when callbacks are triggered after commit" do describe "subscribing to mailchimp newsletter" do let(:user) { build(:user) }