maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix erblint errors on the app/views/internal folder (#8387)

Browse source
This commit is contained in:
Alberto Pérez de Rada Fiol 2020-06-10 18:37:36 +02:00 • committed by GitHub
parent 5f336d9aee
commit 7355bd3ee3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
7 changed files with 6 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/views/internal/articles/index.html.erb
View file

@ -35,7 +35,6 @@
<li class="nav-item">
<a href="/internal/articles?state=satellite-not-buffered" class="nav-link <%= "active" if params[:state] == "satellite-not-buffered" %>">Satellite</a>
</li>
</ul>
<% if params[:state] && params[:state].include?("top-") && params[:state] != "top-3" && params[:state] != "top-6" %>
<h1 style="color:red">

2
app/views/internal/configs/show.html.erb
View file

@ -202,7 +202,7 @@
<div class="form-group">
<div>
<label for="site_config_email_addresses_default">Default</label>
<input type="text" value="<%= ApplicationConfig['DEFAULT_EMAIL'] %>" class="form-control" readonly>
<input type="text" value="<%= ApplicationConfig["DEFAULT_EMAIL"] %>" class="form-control" readonly>
<div class="alert alert-info">Default (set via DEFAULT_EMAIL environment variable)</div>
</div>
<%= f.fields_for :email_addresses do |email_field| %>

7
app/views/internal/feedback_messages/index.html.erb
View file

@ -16,12 +16,7 @@
<%= f.label :reporter_username_cont, "Reporter", class: "sr-only" %>
<%= f.search_field :reporter_username_cont, placeholder: "Reporter", class: "form-control mx-3" %>
<%= f.select(
:status_eq,
options_for_select(["Open", "Invalid", "Resolved"], @q.status_eq),
{ include_blank: true },
class: "custom-select mx-3",
) %>
<%= f.select(:status_eq, options_for_select(%w[Open Invalid Resolved], @q.status_eq), { include_blank: true }, class: "custom-select mx-3") %>
<%= f.submit "Search", class: "btn btn-secondary" %>
<% end %>

2
app/views/internal/organizations/show.html.erb
View file

@ -36,7 +36,7 @@
<%= form_tag update_org_credits_internal_organization_path(@organization), method: :patch, class: "form-inline justify-content-between mb-2" do %>
<div class="form-group">
<%= hidden_field_tag :credit_action, :add %>
<%= number_field_tag :credits, nil, in: 1...100000, required: true, class: "form-control mr-3", size: 5 %>
<%= number_field_tag :credits, nil, in: 1...100_000, required: true, class: "form-control mr-3", size: 5 %>
<%= text_field_tag :note, "", placeholder: "Why are you adding these credits?", size: 50, required: true, class: "form-control mr-3" %>
</div>
<%= submit_tag "Add Org Credits", class: "btn btn-primary" %>

4
app/views/internal/pages/_form.html.erb
View file

@ -57,7 +57,6 @@
<%= link_to "here", "/internal/feature_flags/features/" %>
<% end %>
</br>
</p>
</div>
<%= form.submit class: "btn btn-primary float-right" %>
@ -66,7 +65,6 @@
</div>
<script>
function showBodyFields() {
// hide all optional elements
$('.optional').css('display','none');
@ -80,8 +78,6 @@ function showBodyFields() {
});
};
window.addEventListener('load', function() {
document.getElementById("page_template").onchange = function() {
showBodyFields();

4
app/views/internal/response_templates/_form.html.erb
View file

@ -1,7 +1,7 @@
<%= form_with(model: [:internal, response_template], local: true, html: { class: "mb-5" }) do |f| %>
<div class="form-group">
<%= f.label :type_of, "Type of Response Template" %>
<% type_of_options = [["Mod Comment", "mod_comment"], ["Personal Comment", "personal_comment"], ["Email", "email_reply"], ["Abuse Report Email", "abuse_report_email_reply"]] %>
<% type_of_options = [["Mod Comment", "mod_comment"], ["Personal Comment", "personal_comment"], %w[Email email_reply], ["Abuse Report Email", "abuse_report_email_reply"]] %>
<%= f.select :type_of, options_for_select(type_of_options, response_template.type_of), html: { required: true }, class: "form-control" %>
</div>
<div class="form-group">
@ -14,7 +14,7 @@
</div>
<div class="form-group">
<%= f.label :content_type, "Content Type (for ex. Markdown)", value: response_template.content %>
<% content_type_options = [["Markdown", "body_markdown"], ["Plain Text", "plain_text"], ["HTML", "html"]] %>
<% content_type_options = [%w[Markdown body_markdown], ["Plain Text", "plain_text"], %w[HTML html]] %>
<%= f.select :content_type, options_for_select(content_type_options, response_template.content_type || "plain_text"), class: "form-control" %>
</div>
<div class="form-group">

2
app/views/internal/tools/index.html.erb
View file

@ -1,6 +1,6 @@
<h2>General Purpose URL Purge</h2>
<p>For a page that should 404. This will purge the page via Fastly.</p>
<p>Use the full path (<%= app_url('xyz') %>) or the relative path: (/xyz)</p>
<p>Use the full path (<%= app_url("xyz") %>) or the relative path: (/xyz)</p>
<div class="row m-3">
<%= form_tag bust_cache_internal_tools_path do %>
<div class="form-row">