maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve title parsing logic (#88)

Browse source
This commit is contained in:
Mac Siri 2018-03-16 17:02:32 -04:00 • committed by Ben Halpern
parent c1e623ebc2
commit 6f0a64c83f
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/labor/markdown_fixer.rb
View file

@ -10,7 +10,7 @@ class MarkdownFixer
end
def add_quotes_to_title(markdown)
markdown.gsub(/title:\s?(.*?)\n/m) do |target|
markdown.gsub(/title:\s?(.*?)(\r\n|\n)/m) do |target|
# $1 is the captured group (.*?)
captured_title = $1
# The query below checks if the whole title is wrapped in

11
spec/labor/markdown_fixer_spec.rb
View file

@ -30,10 +30,17 @@ RSpec.describe MarkdownFixer do
end
it "handles complex title" do
legacy_title = %(Book review: "#{sample_title}", part 1 I'm #deep)
expected_title = "\"Book review: \\\"#{sample_title}\\\", part 1 I'm #deep\""
legacy_title = %(Book review: "#{sample_title}", part 1 I'm #testing)
expected_title = "\"Book review: \\\"#{sample_title}\\\", part 1 I'm #testing\""
test = described_class.fix_all(create_sample_markdown(legacy_title))
expect(test).to eq create_sample_markdown(expected_title)
end
it "handles title with \r\n" do
title = "\"hmm\"\r\n"
expected_title = "\"hmm\"\n"
test = described_class.fix_all(create_sample_markdown(title))
expect(test).to eq create_sample_markdown(expected_title)
end
end
end