From 6d6a36f3dd38ffabde5035cf715032b63c47d9a7 Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Mon, 30 Mar 2020 20:43:33 -0400 Subject: [PATCH] [deploy] Fix small onboarding issues (#6963) * Fix small onboarding issues * Fix whitespace --- app/assets/stylesheets/preact/onboarding-modal.scss | 10 ++++++++-- app/controllers/users_controller.rb | 1 + app/javascript/onboarding/components/ClosingSlide.jsx | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/assets/stylesheets/preact/onboarding-modal.scss b/app/assets/stylesheets/preact/onboarding-modal.scss index 4a8623950..f15c513cc 100644 --- a/app/assets/stylesheets/preact/onboarding-modal.scss +++ b/app/assets/stylesheets/preact/onboarding-modal.scss @@ -23,7 +23,6 @@ @media screen and (min-width: 600px) { border-width: 2px; - min-height: auto; } a { @@ -153,7 +152,7 @@ // modal overflow scrolling .onboarding-modal-scroll-container { height: auto; - + min-height: 436px; @media screen and (min-width: $breakpoint-s) { max-height: 500px; overflow-y: scroll; @@ -167,6 +166,7 @@ grid-template-columns: repeat(2, 1fr); grid-gap: $su-4; width: 100%; + min-height: 316px; @media screen and (min-width: 800px) { grid-template-columns: repeat(3, 1fr); @@ -369,6 +369,10 @@ $onboarding-user-selected-hover: rgba(71, 85, 235, 0.2); .user-name { font-size: $fs-base; } + + .user-info { + width: 100%; + } .user-summary { font-size: $fs-s; @@ -384,6 +388,7 @@ $onboarding-user-selected-hover: rgba(71, 85, 235, 0.2); display: flex; flex-direction: column; overflow: auto; + min-height: 250px; @media screen and (min-width: $breakpoint-s) { flex-direction: column; @@ -404,6 +409,7 @@ $onboarding-user-selected-hover: rgba(71, 85, 235, 0.2); padding: 0.25em; position: relative; text-align: center; + box-sizing: border-box; .whatnext-emoji { text-align: center; diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 429de8024..0a0a58a7b 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -145,6 +145,7 @@ class UsersController < ApplicationController if params[:user] permitted_params = %i[summary location employment_title employer_name last_onboarding_page] current_user.assign_attributes(params[:user].permit(permitted_params)) + current_user.profile_updated_at = Time.current end current_user.saw_onboarding = true authorize User diff --git a/app/javascript/onboarding/components/ClosingSlide.jsx b/app/javascript/onboarding/components/ClosingSlide.jsx index 1d5dd5698..927d83b15 100644 --- a/app/javascript/onboarding/components/ClosingSlide.jsx +++ b/app/javascript/onboarding/components/ClosingSlide.jsx @@ -109,6 +109,7 @@ class ClosingSlide extends Component { maxWidth: '66%', margin: 'auto', marginTop: '1.5em', + lineHeight: '1.3em', }} >