From 6c8cbabdff0919eec88aa679e0b75c1dea40503b Mon Sep 17 00:00:00 2001 From: Ridhwana Date: Wed, 15 Apr 2020 13:22:28 +0200 Subject: [PATCH] Remove unused file and fix social media icon css on information page (#7295) * chore: does not look like this file is being used anywhere * fix: the svg's didn't seem to be resizing because we did not have a viewBox tag on the svg * chore: update spec file --- app/assets/images/facebook.svg | 2 +- app/assets/images/github.svg | 2 +- app/assets/images/instagram.svg | 2 +- app/assets/images/twitch.svg | 2 +- app/assets/images/twitter.svg | 2 +- .../comments/_login_cta_comment.html.erb | 27 ------------------- .../liquid_tweet_tag_spec.approved.html | 2 +- 7 files changed, 6 insertions(+), 33 deletions(-) delete mode 100644 app/views/comments/_login_cta_comment.html.erb diff --git a/app/assets/images/facebook.svg b/app/assets/images/facebook.svg index 261d5ff6b..1e7f72265 100644 --- a/app/assets/images/facebook.svg +++ b/app/assets/images/facebook.svg @@ -1 +1 @@ - + diff --git a/app/assets/images/github.svg b/app/assets/images/github.svg index aa2dc0bfa..5ad2f6433 100644 --- a/app/assets/images/github.svg +++ b/app/assets/images/github.svg @@ -1 +1 @@ - + diff --git a/app/assets/images/instagram.svg b/app/assets/images/instagram.svg index b657263fe..f9ed4bacb 100644 --- a/app/assets/images/instagram.svg +++ b/app/assets/images/instagram.svg @@ -1 +1 @@ - + diff --git a/app/assets/images/twitch.svg b/app/assets/images/twitch.svg index 69e0edff3..70b4c05b2 100644 --- a/app/assets/images/twitch.svg +++ b/app/assets/images/twitch.svg @@ -1 +1 @@ - + diff --git a/app/assets/images/twitter.svg b/app/assets/images/twitter.svg index f7956881c..8c786f380 100644 --- a/app/assets/images/twitter.svg +++ b/app/assets/images/twitter.svg @@ -1 +1 @@ - + diff --git a/app/views/comments/_login_cta_comment.html.erb b/app/views/comments/_login_cta_comment.html.erb deleted file mode 100644 index d9b9c5707..000000000 --- a/app/views/comments/_login_cta_comment.html.erb +++ /dev/null @@ -1,27 +0,0 @@ -<% unless user_signed_in? %> -
-
-
-
-
-
-
-

- Hey there, we see you aren't signed in. (Yes you, the reader. This is a fake comment.) -

-

- Please consider creating an account on - <%= community_name %>. It literally takes a few seconds and - we'd appreciate the support so much. ❤️ -

-

Plus, no fake comments when you're signed in. 🙃

- -
- -
-
-<% end %> diff --git a/spec/support/fixtures/approvals/liquid_tweet_tag_spec.approved.html b/spec/support/fixtures/approvals/liquid_tweet_tag_spec.approved.html index e0e87c3a4..7658f96b5 100644 --- a/spec/support/fixtures/approvals/liquid_tweet_tag_spec.approved.html +++ b/spec/support/fixtures/approvals/liquid_tweet_tag_spec.approved.html @@ -18,7 +18,7 @@ @thepracticaldev + twitter logo
When GitHub goes down