diff --git a/spec/requests/admin/data_update_scripts_spec.rb b/spec/requests/admin/data_update_scripts_spec.rb index 1b6857aa2..61047c865 100644 --- a/spec/requests/admin/data_update_scripts_spec.rb +++ b/spec/requests/admin/data_update_scripts_spec.rb @@ -5,6 +5,7 @@ RSpec.describe "/admin/data_update_scripts", type: :request do context "when the user is not an tech admin" do let(:user) { create(:user) } + before { sign_in user } describe "GET /admin/data_update_scripts" do @@ -36,20 +37,20 @@ RSpec.describe "/admin/data_update_scripts", type: :request do end it "displays a 'Rerun' button when the script status is failed" do - script = create(:data_update_script, status: "failed") + create(:data_update_script, status: "failed") get_resource expect(response.body).to include("Re-run") end end describe "GET /admin/data_update_scripts/:id" do - let(:script) { + let(:script) do create( :data_update_script, - file_name: '20200214151804_data_update_test_script', - status: "succeeded" + file_name: "20200214151804_data_update_test_script", + status: "succeeded", ) - } + end let(:script_id) { script.id } it "returns a data update script" do @@ -63,7 +64,7 @@ RSpec.describe "/admin/data_update_scripts", type: :request do end describe "POST /admin/:id/force_run" do - let(:script) { create(:data_update_script, file_name: '20200214151804_data_update_test_script') } + let(:script) { create(:data_update_script, file_name: "20200214151804_data_update_test_script") } let(:script_id) { script.id.to_s } it "calls the the sidekiq worker" do diff --git a/spec/workers/data_update_worker_spec.rb b/spec/workers/data_update_worker_spec.rb index aa7caad57..5169959e0 100644 --- a/spec/workers/data_update_worker_spec.rb +++ b/spec/workers/data_update_worker_spec.rb @@ -11,11 +11,11 @@ RSpec.describe DataUpdateWorker, type: :worker do end context "when an id is passed" do - it "it updates the appropriate script" do + it "updates the appropriate script" do script = create( :data_update_script, file_name: "20200214151804_data_update_test_script", - status: "failed" + status: "failed", ) expect do @@ -27,7 +27,6 @@ RSpec.describe DataUpdateWorker, type: :worker do end end - context "when an id is not passed" do it "runs scripts that need running" do expect do