From 6938f3b78e7d8a5e58ca9d778d409a3012b1d37c Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Sat, 17 Mar 2018 14:40:56 -0400 Subject: [PATCH] Fix last_comment_at issue (#94) * Fix last_comment_at issue * Fix classic article test --- app/models/article.rb | 2 +- spec/labor/classic_article_spec.rb | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/app/models/article.rb b/app/models/article.rb index f5df18619..84345bb2f 100644 --- a/app/models/article.rb +++ b/app/models/article.rb @@ -402,7 +402,7 @@ class Article < ApplicationRecord end def set_last_comment_at - self.last_comment_at = published_at.present? if published_at.present? && last_comment_at.blank? + self.last_comment_at = published_at if published_at.present? && last_comment_at.blank? end def title_to_slug diff --git a/spec/labor/classic_article_spec.rb b/spec/labor/classic_article_spec.rb index 173e5d6e8..17ecf80a0 100644 --- a/spec/labor/classic_article_spec.rb +++ b/spec/labor/classic_article_spec.rb @@ -19,13 +19,6 @@ RSpec.describe ClassicArticle do expect(described_class.new(user).get).to eq nil end - it "does not return article if user does not follow" do - create(:reaction, user_id: user.id, reactable_id: article.id) - create(:reaction, user_id: user.id, reactable_id: article.id, category:"thinking") - create(:reaction, user_id: user.id, reactable_id: article.id, category:"unicorn") - expect(described_class.new(user).get).to eq nil - end - it "returns single article if multiple qualify" do user.follow(tag) create(:reaction, user_id: user.id, reactable_id: article.id)