From 64c10957e3400e8009fdec99c60424a869cd0a53 Mon Sep 17 00:00:00 2001 From: Mac Siri Date: Wed, 29 Mar 2023 17:20:41 -0400 Subject: [PATCH] Update CODEOWNERS (#19276) --- .github/CODEOWNERS | 67 ++++++++++++------------------------- .github/workflows/ci-cd.yml | 2 +- 2 files changed, 23 insertions(+), 46 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index cbd1dda33..4b2728754 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -2,50 +2,27 @@ # see https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners # for further details +# Default global ownership +* @forem/core-reviewers -# File exentions based ownership -# -# They are: .builder, .css, .erb, .gif, .ico, .jbuilder, .js, .jsx, -# .map, .md, .mdx, .otf, .png, .rake, .rb, .scss, .snap, -# .svg, .toml, .xml -# -# Use the following to generate the list: -# -# * `tree app | rg "\.\w+$" --only-matching | sort | uniq` -# * `tree lib | rg "\.\w+$" --only-matching | sort | uniq` -# -**/*.builder @forem/core-reviewers -**/*.css @forem/core-reviewers -**/*.erb @forem/core-reviewers -**/*.jbuilder @forem/core-reviewers -**/*.js @forem/core-reviewers -**/*.json @forem/core-reviewers -**/*.jsx @forem/core-reviewers -**/*.md @forem/core-reviewers -**/*.rb @forem/core-reviewers -**/*.scss @forem/core-reviewers +# Dependency ownership +Gemfile @forem/core-reviewers @forem/platform +Gemfile.lock @forem/core-reviewers @forem/platform +package.json @forem/core-reviewers @forem/platform +yarn.lock @forem/core-reviewers @forem/platform -# Context based ownership -/app/assets/ @forem/core-reviewers -/app/controllers/async_info_controller.rb @forem/sre -/app/javascript/ @forem/core-reviewers -/app/services/search/ @forem/sre -/app/workers/ @forem/sre -/config/ @forem/sre -/config/locales -/db/ @forem/sre @forem/core-reviewers -/lib/data_update_scripts/ @forem/sre -/lib/sidekiq/ @forem/sre -/spec/rails_helper.rb @forem/sre @forem/core-reviewers -/spec/support/ @forem/sre -.buildkite/ @forem/systems @forem/sre -.travis.yml @forem/sre -Containerfile @forem/systems -docker-compose.yml @forem/systems -Dockerfile @forem/systems -Gemfile @forem/core-reviewers @forem/sre -Gemfile.lock @forem/core-reviewers @forem/sre -package.json @forem/core-reviewers -podman-compose.yml @forem/systems -scripts/ @forem/systems -yarn.lock @forem/core-reviewers +# Platform specific ownership +.buildkite/ @forem/platform @forem/core-reviewers +Containerfile @forem/platform @forem/core-reviewers +Dockerfile @forem/platform @forem/core-reviewers +app/controllers/async_info_controller.rb @forem/platform @forem/core-reviewers +app/services/search/ @forem/platform @forem/core-reviewers +app/workers/ @forem/platform @forem/core-reviewers +config/ @forem/platform @forem/core-reviewers +db/ @forem/platform @forem/core-reviewers +docker-compose.yml @forem/platform @forem/core-reviewers +lib/ @forem/platform @forem/core-reviewers +podman-compose.yml @forem/platform @forem/core-reviewers +scripts/ @forem/platform @forem/core-reviewers +spec/rails_helper.rb @forem/platform @forem/core-reviewers +spec/support/ @forem/platform @forem/core-reviewers diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 18706d08e..148c68b0c 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -384,7 +384,7 @@ jobs: - uses: codecov/codecov-action@v3 with: flags: cypress, javascript - fail_ci_if_error: true + fail_ci_if_error: false - name: Upload test results to BuildPulse for flaky test detection if: '!cancelled()' # Run this step even when the tests fail. Skip if the workflow is cancelled. uses: Workshop64/buildpulse-action@master