maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[deploy] Optimization: Eager Load and Limit Columns When Fetching Articles Not IDs (#8719)

Browse source
This commit is contained in:
Molly Struve 2020-06-17 09:51:44 -05:00 • committed by GitHub
parent 7309478420
commit 5dfdb2bf4d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/services/suggester/articles/classic.rb
View file

@ -14,20 +14,18 @@ module Suggester
articles = if rand(8) == 1
random_high_quality_articles(num)
else
qualifying_ids = qualifying_articles(random_supported_tag_names)
qualifying_ids = qualifying_article_ids(random_supported_tag_names)
lookup_ids = qualifying_ids - not_ids
Article.where(id: lookup_ids).limit(num)
Article.includes(:user).limited_column_select.where(id: lookup_ids).limit(num)
end
articles = random_high_quality_articles(num) if articles.empty?
articles
end
def qualifying_articles(tag_names)
def qualifying_article_ids(tag_names)
tag_name = tag_names.sample
Rails.cache.fetch("classic-article-ids-for-tag-#{tag_name}", expires_in: 90.minutes) do
Article.published.cached_tagged_with(tag_name).
includes(:user).
limited_column_select.
where(featured: true).
where("public_reactions_count > ?", MIN_REACTION_COUNT).
where("published_at > ?", 10.months.ago).