From 5d00a4d967f9df9508dac9f379e3d65d4630e2ff Mon Sep 17 00:00:00 2001 From: Jamie Gaskins Date: Tue, 8 Feb 2022 10:41:54 -0500 Subject: [PATCH] Show image-upload errors on /admin/advanced/tools (#16448) * Show image-upload errors on /admin/advanced/tools * Simplify error handling This also makes the error message consistent with the rest of the admin validation errors, so it's probably better even if it doesn't look as flashy. * Remove obsolete clearTimeout call We aren't setting this timer anymore --- .../admin/controllers/image_upload_controller.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/app/javascript/admin/controllers/image_upload_controller.js b/app/javascript/admin/controllers/image_upload_controller.js index c68868405..913ffd387 100644 --- a/app/javascript/admin/controllers/image_upload_controller.js +++ b/app/javascript/admin/controllers/image_upload_controller.js @@ -1,4 +1,5 @@ import { Controller } from '@hotwired/stimulus'; +import { displayErrorAlert } from '../messageUtilities'; export default class ImageUploadController extends Controller { static targets = ['fileField', 'imageResult']; @@ -29,7 +30,8 @@ export default class ImageUploadController extends Controller { } const { links } = json; return this.onUploadSuccess(links); - }); + }) + .catch(this.onUploadFailure); } onUploadSuccess(result) { @@ -45,4 +47,8 @@ export default class ImageUploadController extends Controller { `; this.imageResultTarget.innerHTML = output; } + + onUploadFailure(error) { + displayErrorAlert(error.message); + } }