From 5afcdb3f7123837984136ca6d87a3983f06354df Mon Sep 17 00:00:00 2001 From: Julianna Tetreault <32834804+juliannatetreault@users.noreply.github.com> Date: Fri, 28 Jan 2022 09:13:35 -0700 Subject: [PATCH] Add admin_member_view Feature Flag (#16346) * Adds an admin_member_view feature flag and spec * Adds the admin_member_view FeatureFlag to seeds_e2e for testing --- ...0709_add_admin_member_view_feature_flag.rb | 7 ++++++ ...add_admin_member_view_feature_flag_spec.rb | 24 +++++++++++++++++++ spec/support/seeds/seeds_e2e.rb | 5 ++++ 3 files changed, 36 insertions(+) create mode 100644 lib/data_update_scripts/20220128150709_add_admin_member_view_feature_flag.rb create mode 100644 spec/lib/data_update_scripts/add_admin_member_view_feature_flag_spec.rb diff --git a/lib/data_update_scripts/20220128150709_add_admin_member_view_feature_flag.rb b/lib/data_update_scripts/20220128150709_add_admin_member_view_feature_flag.rb new file mode 100644 index 000000000..3d771d56b --- /dev/null +++ b/lib/data_update_scripts/20220128150709_add_admin_member_view_feature_flag.rb @@ -0,0 +1,7 @@ +module DataUpdateScripts + class AddAdminMemberViewFeatureFlag + def run + FeatureFlag.add(:admin_member_view) + end + end +end diff --git a/spec/lib/data_update_scripts/add_admin_member_view_feature_flag_spec.rb b/spec/lib/data_update_scripts/add_admin_member_view_feature_flag_spec.rb new file mode 100644 index 000000000..a613dbb2c --- /dev/null +++ b/spec/lib/data_update_scripts/add_admin_member_view_feature_flag_spec.rb @@ -0,0 +1,24 @@ +require "rails_helper" +require Rails.root.join( + "lib/data_update_scripts/20220128150709_add_admin_member_view_feature_flag.rb", +) + +describe DataUpdateScripts::AddAdminMemberViewFeatureFlag do + after do + FeatureFlag.remove(:admin_member_view) + end + + it "adds the :admin_member_view flag" do + expect do + described_class.new.run + end.to change { FeatureFlag.exist?(:admin_member_view) }.from(false).to(true) + end + + it "works if the flag is already available" do + FeatureFlag.add(:admin_member_view) + + expect do + described_class.new.run + end.not_to change { FeatureFlag.exist?(:admin_member_view) } + end +end diff --git a/spec/support/seeds/seeds_e2e.rb b/spec/support/seeds/seeds_e2e.rb index 8b96d95db..b8ab6a12c 100644 --- a/spec/support/seeds/seeds_e2e.rb +++ b/spec/support/seeds/seeds_e2e.rb @@ -64,6 +64,11 @@ admin_user = User.find_by(email: "admin@forem.local") ############################################################################## +# Enable Admin Member View feature flag for tests +FeatureFlag.enable(:admin_member_view) + +############################################################################## + seeder.create_if_doesnt_exist(User, "email", "trusted-user-1@forem.local") do user = User.create!( name: "Trusted User 1 \\:/",