maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ensure COC and TOS Links Open on the Creator Settings Form (#15634)

Browse source 
* Opens COC and TOS links in new window, w/o redirects

* Removes superfluous > from the Creator Settings _form
This commit is contained in:
Julianna Tetreault 2021-12-02 08:10:08 -07:00 • committed by GitHub
parent 4e980b72ff
commit 59765b7ba6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/javascript/packs/onboardingRedirectCheck.jsx
View file

@ -14,6 +14,8 @@ function redirectableLocation() {
window.location.pathname !== '/onboarding' &&
window.location.pathname !== '/signout_confirm' &&
window.location.pathname !== '/privacy' &&
window.location.pathname !== '/code-of-conduct' &&
window.location.pathname !== '/terms' &&
window.location.pathname !== '/admin/creator_settings/new'
);
}

4
app/views/admin/creator_settings/_form.html.erb
View file

@ -90,12 +90,12 @@
<div class="mb-2">
<%= hidden_field_tag :checked_code_of_conduct, "0" %>
<%= check_box_tag :checked_code_of_conduct, "1", false, class: "crayons-checkbox", required: true %>
<label for="checked_code_of_conduct">I agree to uphold our <a href="/code-of-conduct">Code of Conduct</a>.</label>
<label for="checked_code_of_conduct">I agree to uphold our <a href="/code-of-conduct" target="code-of-conduct">Code of Conduct</a>.</label>
</div>
<div>
<%= hidden_field_tag :checked_terms_and_conditions, "0" %>
<%= check_box_tag :checked_terms_and_conditions, "1", false, class: "crayons-checkbox", required: true %>
<label for="checked_terms_and_conditions">I agree to our <a href="/terms">Terms and Conditions</a>.</label>
<label for="checked_terms_and_conditions">I agree to our <a href="/terms" target="terms-and-conditions">Terms and Conditions</a>.</label>
</div>
</div>
</fieldset>