diff --git a/Gemfile.lock b/Gemfile.lock index a927482fc..a9606ce48 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -664,7 +664,7 @@ GEM ffi (~> 1.0) recaptcha (5.12.3) json - redcarpet (3.5.1) + redcarpet (3.6.0) redis (4.7.1) redis-actionpack (5.3.0) actionpack (>= 5, < 8) diff --git a/spec/services/markdown_processor/parser_spec.rb b/spec/services/markdown_processor/parser_spec.rb index 300b78720..d961c5493 100644 --- a/spec/services/markdown_processor/parser_spec.rb +++ b/spec/services/markdown_processor/parser_spec.rb @@ -38,13 +38,6 @@ RSpec.describe MarkdownProcessor::Parser, type: :service do expect(number_of_triple_backticks).to eq(2) end - # TODO: @zhao-andy this should fail if this issue is solved: https://github.com/forem/forem/issues/13823 - it "escapes triple backticks within a codeblock when using tildes" do - code_block = "~~~\nhello\n```\nwhatever\n```\n~~~" - number_of_triple_backticks = generate_and_parse_markdown(code_block).scan("```").count - expect(number_of_triple_backticks).to eq(0) - end - it "does not remove the non-'raw tag related' four dashes" do code_block = "```\n----\n```" expect(generate_and_parse_markdown(code_block)).to include("----") @@ -274,7 +267,7 @@ RSpec.describe MarkdownProcessor::Parser, type: :service do context "when provided with an @username" do context "when html has injected styles" do before do - create :user, username: "User1" + create(:user, username: "User1") end let(:suspicious) do @@ -285,7 +278,7 @@ RSpec.describe MarkdownProcessor::Parser, type: :service do end it "strips the styles as expected" do - linked_user = %(@user1) + linked_user = %(@user1) expected_result = <<~HTML.strip
x{animation:s}#{linked_user} s{}<br> <style>{transition:color 1s}:hover{color:red}</p> diff --git a/vendor/cache/redcarpet-3.5.1.gem b/vendor/cache/redcarpet-3.5.1.gem deleted file mode 100644 index f510fa350..000000000 Binary files a/vendor/cache/redcarpet-3.5.1.gem and /dev/null differ diff --git a/vendor/cache/redcarpet-3.6.0.gem b/vendor/cache/redcarpet-3.6.0.gem new file mode 100644 index 000000000..339a9924b Binary files /dev/null and b/vendor/cache/redcarpet-3.6.0.gem differ