From 55997ffba89ff140bbe29eacdb22fcad900fef73 Mon Sep 17 00:00:00 2001 From: Ben Halpern Date: Tue, 5 Dec 2023 09:02:27 -0500 Subject: [PATCH] Hide images if error on billboards to fix blocking page (#20419) * Hide images if error on billboards * Update app/javascript/packs/billboard.js --- app/assets/stylesheets/themes/dark.css | 4 ++++ app/javascript/packs/billboard.js | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/app/assets/stylesheets/themes/dark.css b/app/assets/stylesheets/themes/dark.css index 1cb9c0159..7f6eae747 100644 --- a/app/assets/stylesheets/themes/dark.css +++ b/app/assets/stylesheets/themes/dark.css @@ -279,6 +279,10 @@ --indicator-bg: rgb(var(--grey-600)); --indicator-color: rgb(var(--grey-200)); + /* Indicators: Subtle */ + --indicator-subtle-bg: rgb(var(--grey-700)); + --indicator-subtle-color: rgb(var(--grey-200)); + /* Indicators: Success */ --indicator-success-bg: rgb(var(--green-700)); --indicator-success-color: rgb(var(--green-50)); diff --git a/app/javascript/packs/billboard.js b/app/javascript/packs/billboard.js index 1fa677ac3..4a352e0fc 100644 --- a/app/javascript/packs/billboard.js +++ b/app/javascript/packs/billboard.js @@ -29,6 +29,11 @@ async function generateBillboard(element) { element.innerHTML = ''; element.appendChild(generatedElement); + element.querySelectorAll('img').forEach((img) => { + img.onerror = function () { + this.style.display = 'none'; + }; + }); executeBBScripts(element); setupBillboardDropdown(); // This is called here because the ad is loaded asynchronously.