maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix required button styling in SiteConfig (#10857) [deploy]

Browse source 
* Use crayons-indicator--critical class when rendering Required note

* Add a bit of padding to the site-config label to give button room
This commit is contained in:
Vaidehi Joshi 2020-10-14 15:04:36 -07:00 • committed by GitHub
parent 5b211e33d7
commit 54cb0ecefe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/assets/stylesheets/admin.scss
View file

@ -56,6 +56,7 @@ label {
.site-config__label { .site-config__label {
display: flex; display: flex;
justify-content: space-between; justify-content: space-between;
padding-bottom: var(--su-2);
} }
.profile__group-toggle { .profile__group-toggle {

2
app/helpers/application_helper.rb
View file

@ -285,7 +285,7 @@ module ApplicationHelper
def admin_config_label(method, content = nil) def admin_config_label(method, content = nil)
content ||= raw("<span>#{method.to_s.humanize}</span>") content ||= raw("<span>#{method.to_s.humanize}</span>")
if method.to_sym.in?(VerifySetupCompleted::MANDATORY_CONFIGS) if method.to_sym.in?(VerifySetupCompleted::MANDATORY_CONFIGS)
content = safe_join([content, raw("<span class='crayons-indicator'>Required</span>")]) content = safe_join([content, raw("<span class='crayons-indicator crayons-indicator--critical'>Required</span>")])
end end
tag.label(content, class: "site-config__label crayons-field__label", for: "site_config_#{method}") tag.label(content, class: "site-config__label crayons-field__label", for: "site_config_#{method}")