maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove useEffect from RuntimeBanner component (#14248)

Browse source
This commit is contained in:
Fernando Valverde 2021-07-15 10:57:57 -06:00 • committed by GitHub
parent 355881f744
commit 50601efe9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
app/javascript/runtimeBanner/RuntimeBanner.jsx
View file

@ -1,7 +1,6 @@
/* global Runtime */
import { h } from 'preact';
import { useEffect } from 'preact/hooks';
const BANNER_DISMISS_KEY = 'runtimeBannerDismissed';
@ -63,26 +62,24 @@ function handleDeepLinkFallback() {
* keep track of this in localStorage so it won't be rendered again.
*/
export const RuntimeBanner = () => {
useEffect(() => {
// The banner shouldn't appear if it was already dismissed or if it doesn't match the context
if (
localStorage.getItem(BANNER_DISMISS_KEY) ||
Runtime.currentContext() !== 'Browser-iOS'
) {
removeFromDOM();
return;
}
// The banner shouldn't appear if it was already dismissed or if it doesn't match the context
if (
localStorage.getItem(BANNER_DISMISS_KEY) ||
Runtime.currentContext() !== 'Browser-iOS'
) {
removeFromDOM();
return;
}
// If we land on `/r/mobile` it means the automatic (i.e. Universal Links)
// deep linking didn't go through and we want to rely on the fallback
// mechanisms (i.e. custom scheme) to open the apps.
// Also, we should never render the banner in this fallback path.
if (window.location.pathname === '/r/mobile') {
removeFromDOM();
handleDeepLinkFallback();
return;
}
}, []);
// If we land on `/r/mobile` it means the automatic (i.e. Universal Links)
// deep linking didn't go through and we want to rely on the fallback
// mechanisms (i.e. custom scheme) to open the apps.
// Also, we should never render the banner in this fallback path.
if (window.location.pathname === '/r/mobile') {
removeFromDOM();
handleDeepLinkFallback();
return;
}
const targetPath = `https://${window.location.host}/r/mobile?deep_link=${window.location.pathname}`;
const targetURL = `https://udl.forem.com/?r=${encodeURIComponent(