From 4ca995e1a192398fc3ba990f0ece7c69bef36d79 Mon Sep 17 00:00:00 2001 From: rhymes Date: Tue, 27 Apr 2021 16:07:05 +0200 Subject: [PATCH] Serialize tag flares correctly in Homepage::ArticleSerializer (#13537) --- app/serializers/homepage/article_serializer.rb | 2 +- spec/services/homepage/fetch_articles_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/serializers/homepage/article_serializer.rb b/app/serializers/homepage/article_serializer.rb index 96aa7ce4e..9f148be91 100644 --- a/app/serializers/homepage/article_serializer.rb +++ b/app/serializers/homepage/article_serializer.rb @@ -16,7 +16,7 @@ module Homepage attribute :video_duration_string, &:video_duration_in_minutes attribute :published_at_int, ->(article) { article.published_at.to_i } attribute :tag_list, ->(article) { article.cached_tag_list.to_s.split(", ") } - attribute :tag_flare, ->(article, params) { params[:tag_flares][article.id] } + attribute :flare_tag, ->(article, params) { params.dig(:tag_flares, article.id) } attribute :user do |article| user = article.user diff --git a/spec/services/homepage/fetch_articles_spec.rb b/spec/services/homepage/fetch_articles_spec.rb index 5b0853d7d..acaf83fd5 100644 --- a/spec/services/homepage/fetch_articles_spec.rb +++ b/spec/services/homepage/fetch_articles_spec.rb @@ -12,8 +12,8 @@ RSpec.describe Homepage::FetchArticles, type: :service do result = described_class.call.first keys = %i[ - class_name cloudinary_video_url comments_count id path public_reactions_count - published_at_int readable_publish_date reading_time tag_flare tag_list title + class_name cloudinary_video_url comments_count flare_tag id path public_reactions_count + published_at_int readable_publish_date reading_time tag_list title user user_id video_duration_string ] expect(result.keys.sort).to eq(keys) @@ -28,7 +28,7 @@ RSpec.describe Homepage::FetchArticles, type: :service do expect(result[:published_at_int]).to eq(article.published_at.to_i) expect(result[:readable_publish_date]).to eq(article.readable_publish_date) expect(result[:reading_time]).to eq(article.reading_time) - expect(result[:tag_flare]).to eq(Homepage::FetchTagFlares.call([article])[article.id]) + expect(result[:flare_tag]).to eq(Homepage::FetchTagFlares.call([article])[article.id]) expect(result[:tag_list]).to eq(article.tag_list) expect(result[:title]).to eq(article.title)