diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 359304edb..e7c9168c5 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -60,6 +60,9 @@ jobs: - name: RSpec run: bin/knapsack_pro_rspec - uses: codecov/codecov-action@v3 + with: + fail_ci_if_error: true + flags: ruby - name: Upload test results to BuildPulse for flaky test detection if: '!cancelled()' # Run this step even when the tests fail. Skip if the workflow is cancelled. uses: Workshop64/buildpulse-action@master @@ -101,6 +104,9 @@ jobs: key: ${{ secrets.BUILDPULSE_ACCESS_KEY_ID }} secret: ${{ secrets.BUILDPULSE_SECRET_ACCESS_KEY }} - uses: codecov/codecov-action@v3 + with: + fail_ci_if_error: true + flags: javascript - run: yarn build-storybook Build-test: diff --git a/bin/knapsack_pro_rspec b/bin/knapsack_pro_rspec index feffe1371..0b4a50d5c 100755 --- a/bin/knapsack_pro_rspec +++ b/bin/knapsack_pro_rspec @@ -3,7 +3,7 @@ if [ "$KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC" = "" ]; then KNAPSACK_PRO_ENDPOINT=https://api-disabled-for-fork.knapsackpro.com \ KNAPSACK_PRO_MAX_REQUEST_RETRIES=0 \ KNAPSACK_PRO_TEST_SUITE_TOKEN_RSPEC=disabled-for-fork \ - bundle exec rake "knapsack_pro:rspec[--format documentation --format RspecJunitFormatter --out tmp/rspec.xml]" + bundle exec rake "knapsack_pro:rspec[--format RspecJunitFormatter --out tmp/rspec.xml]" else - bundle exec rake "knapsack_pro:queue:rspec[--format documentation --format RspecJunitFormatter --out tmp/rspec.xml]" + bundle exec rake "knapsack_pro:queue:rspec[--format RspecJunitFormatter --out tmp/rspec.xml]" fi diff --git a/codecov.yml b/codecov.yml index 141942786..af8758e64 100644 --- a/codecov.yml +++ b/codecov.yml @@ -6,10 +6,7 @@ ignore: - "lib/generators" flag_management: default_rules: - carryforward: true statuses: - type: project target: auto threshold: 1% - - type: patch - target: 90%