maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update TagsController#index query (#15202)

Browse source 
* Update TagsController#index query

to include empty string

* Update spec
This commit is contained in:
Mac Siri 2021-10-27 08:17:53 -04:00 • committed by GitHub
parent c5a5c9c382
commit 3c204c236d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/tags_controller.rb
View file

@ -17,7 +17,7 @@ class TagsController < ApplicationController
def index
skip_authorization
@tags_index = true
@tags = Tag.where(alias_for: nil).includes(:sponsorship).order(hotness_score: :desc).limit(100)
@tags = Tag.where(alias_for: [nil, ""]).includes(:sponsorship).order(hotness_score: :desc).limit(100)
end
def edit

5
spec/requests/tags_spec.rb
View file

@ -3,8 +3,11 @@ require "rails_helper"
RSpec.describe "Tags", type: :request, proper_status: true do
describe "GET /tags" do
it "returns proper page" do
create(:tag, name: "ruby")
create(:tag, name: "javascript", alias_for: "")
get tags_path
expect(response.body).to include("Top tags")
expect(response.body).to include("Top tags", "ruby", "javascript")
end
it "does not include tags with alias" do