maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Flaky Spec Fix:Ensure Page View Domains are Unique for Analytics Service Spec (#10329)

Browse source
This commit is contained in:
Molly Struve 2020-09-14 13:41:14 -05:00 • committed by GitHub
parent 7dcf2ad97e
commit 3a04f742f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
spec/services/analytics_service_spec.rb
View file

@ -424,7 +424,9 @@ RSpec.describe AnalyticsService, type: :service do
end
it "returns 20 domains at most by default" do
21.times { create(:page_view, user: user, article: article, referrer: Faker::Internet.url) } # rubocop:disable FactoryBot/CreateList
21.times do |n|
create(:page_view, user: user, article: article, referrer: "http://fakeurl#{n}.com")
end
expect(analytics_service.referrers[:domains].size).to eq(20)
end