maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixing id and class of non featured article (#10247)

Browse source 
* Fixing id and class of non featured article

* Adding id

* Removing extra space

* Fixing broken rspec test
This commit is contained in:
Rafi 2020-09-09 04:08:49 +05:30 • committed by GitHub
parent c71f179b28
commit 327fe14ccb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/javascript/articles/Article.jsx
View file

@ -44,10 +44,10 @@ export const Article = ({
return (
<article
className={`crayons-story cursor-pointer ${
isFeatured && 'crayons-story--featured'
className={`crayons-story cursor-pointer${
isFeatured ? ' crayons-story--featured' : ''
}`}
id={isFeatured && 'featured-story-marker'}
id={isFeatured ? 'featured-story-marker' : `article-${article.id}`}
data-content-user-id={article.user_id}
data-testid={isFeatured ? 'featured-article' : `article-${article.id}`}
>

6
spec/system/articles/user_visits_articles_by_timeframe_spec.rb
View file

@ -13,8 +13,10 @@ RSpec.describe "User visits articles by timeframe", type: :system do
end
def shows_correct_articles_count_via_xpath(count)
expect(page).to have_xpath("//article[contains(@class, 'crayons-story') and contains(@class, 'false')]",
count: count)
expect(page).to have_xpath(
"//article[contains(@class, 'crayons-story') and not(contains(@class, 'crayons-story--featured'))]",
count: count,
)
end
def shows_main_article