From 2fadc24d287b000a800ca8db7eff9c0d49b0818f Mon Sep 17 00:00:00 2001 From: Vaidehi Joshi Date: Tue, 14 Jul 2020 08:12:07 -0700 Subject: [PATCH] Fix TypeError: null is not an object in initializeArticleReactions.js (#9297) [deploy] * Fix TypeError: null is not an object in initializeArticleReactions.js Should fix https://app.honeybadger.io/fault/67192/6f9b4fdf475e2229c968fa26d785b90f * Return 0 rather than undefined if reactionEl doesn't exist --- .../initializers/initializeArticleReactions.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/initializers/initializeArticleReactions.js b/app/assets/javascripts/initializers/initializeArticleReactions.js index d7b2b2775..3f369c946 100644 --- a/app/assets/javascripts/initializers/initializeArticleReactions.js +++ b/app/assets/javascripts/initializers/initializeArticleReactions.js @@ -40,12 +40,12 @@ function hasUserReacted(reactionName) { } function getNumReactions(reactionName) { - var num = document.getElementById('reaction-number-' + reactionName) - .textContent; - if (num === '') { + const reactionEl = document.getElementById('reaction-number-' + reactionName); + if (!reactionEl || reactionEl.textContent === '') { return 0; } - return parseInt(num, 10); + + return parseInt(reactionEl.textContent, 10); } function reactToArticle(articleId, reaction) {