Bump rubocop from 1.23.0 to 1.24.0 (#15872)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Kohl <me@citizen428.net>

Gemfile

@@ -148,7 +148,7 @@ group :development, :test do
   gem "pry", "~> 0.14" # An IRB alternative and runtime developer console
   gem "pry-rails", "~> 0.3" # Use Pry as your rails console
   gem "rspec-rails", "~> 5.0" # rspec-rails is a testing framework for Rails 3+
-  gem "rubocop", "~> 1.23", require: false # Automatic Ruby code style checking tool
+  gem "rubocop", "~> 1.24", require: false # Automatic Ruby code style checking tool
   gem "rubocop-performance", "~> 1.12", require: false # A collection of RuboCop cops to check for performance optimizations in Ruby code
   gem "rubocop-rails", "~> 2.12", require: false # Automatic Rails code style checking tool
   gem "rubocop-rspec", "~> 2.6", require: false # Code style checking for RSpec files

Gemfile.lock

@@ -644,7 +644,7 @@ GEM
       redis-store (>= 1.2, < 2)
     redis-store (1.9.0)
       redis (>= 4, < 5)
-    regexp_parser (2.1.1)
+    regexp_parser (2.2.0)
     reline (0.2.7)
       io-console (~> 0.5)
     request_store (1.5.0)
@@ -696,16 +696,16 @@ GEM
     rspec-support (3.10.2)
     rss (0.2.9)
       rexml
-    rubocop (1.23.0)
+    rubocop (1.24.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.12.0, < 2.0)
+      rubocop-ast (>= 1.15.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.13.0)
+    rubocop-ast (1.15.0)
       parser (>= 3.0.1.1)
     rubocop-performance (1.12.0)
       rubocop (>= 1.7.0, < 2.0)
@@ -1029,7 +1029,7 @@ DEPENDENCIES
   rspec-rails (~> 5.0)
   rspec-retry (~> 0.6)
   rss (~> 0.2.9)
-  rubocop (~> 1.23)
+  rubocop (~> 1.24)
   rubocop-performance (~> 1.12)
   rubocop-rails (~> 2.12)
   rubocop-rspec (~> 2.6)

app/validators/emoji_only_validator.rb

@@ -2,7 +2,7 @@ class EmojiOnlyValidator < ActiveModel::EachValidator
   DEFAULT_MESSAGE = "contains non-emoji characters or invalid emoji".freeze
 
   def validate_each(record, attribute, value)
-    return unless value 
+    return unless value
     return if value.gsub(EmojiRegex::RGIEmoji, "").blank?
 
     record.errors.add(attribute, options[:message] || DEFAULT_MESSAGE)

config/initializers/sprockets_uglifier_with_source_maps_compressor.rb

@@ -25,7 +25,7 @@ module Sprockets
       sourcemap_url  = filename_to_url(sourcemap_filename)
 
       FileUtils.mkdir_p File.dirname(sourcemap_path)
-      File.open(sourcemap_path, "w") { |f| f.write sourcemap_json }
+      File.write(sourcemap_path, sourcemap_json)
 
       # Add the source map URL to the compressed JS file.
       compressed_data.concat "\n//# sourceMappingURL=#{sourcemap_url}\n"