maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix flaky cypress specs (#20579)

Browse source
This commit is contained in:
Mac Siri 2024-02-01 17:54:19 -05:00 • committed by GitHub
parent 9b93b12f05
commit 2746586eea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 20 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
cypress/e2e/seededFlows/articleFlows/followOrganization.spec.js
View file

@ -4,24 +4,23 @@ describe('Follow an organization from article sidebar', () => {
cy.viewport('macbook-16');
cy.fixture('users/articleEditorV1User.json').as('user');
cy.intercept('GET', '/follows/*').as('follows');
cy.get('@user').then((user) => {
cy.loginAndVisit(
user,
'/admin_mcadmin/test-organization-article-slug',
).then(() => {
cy.get('[data-follow-clicks-initialized]');
cy.findByRole('heading', { name: 'Organization test article' });
});
cy.loginAndVisit(user, '/admin_mcadmin/test-organization-article-slug');
});
cy.wait('@follows');
cy.get('[data-follow-clicks-initialized]');
cy.findByRole('heading', { name: 'Organization test article' });
});
it('Follows an organization from the sidebar', () => {
it('Follows and unfollow an organization from the sidebar', () => {
cy.intercept('/follows').as('followRequest');
cy.contains('Follow').as('followButton');
// Follow
cy.get('@followButton').click();
cy.wait('@followRequest');
cy.get('@followButton').should('have.text', 'Following');
cy.get('@followButton').should('have.attr', 'aria-pressed', 'true');
@ -35,18 +34,17 @@ describe('Follow an organization from article sidebar', () => {
cy.findByRole('main')
.findByRole('link', { name: 'Bachmanity' })
.should('exist');
});
it('Unfollows an organization from the sidebar', () => {
cy.intercept('/follows').as('followRequest');
cy.contains('Follow').as('followButton');
// Follow
cy.get('@followButton').click();
// Unfollow
cy.visitAndWaitForUserSideEffects(
'/admin_mcadmin/test-organization-article-slug',
);
// cy.intercept('/follows').as('followRequest');
cy.contains('Following').as('followButton');
cy.get('@followButton').click();
cy.wait('@followRequest');
cy.contains('Following').should('not.exist');
cy.contains('Follow').as('followButton');
cy.get('@followButton').should('have.text', 'Follow');
cy.get('@followButton').should('have.attr', 'aria-pressed', 'false');

8
cypress/e2e/seededFlows/moderationFlows/adjustPostTags.spec.js
View file

@ -16,9 +16,7 @@ describe('Adjust post tags', () => {
.should('not.exist');
cy.getIframeBody('.actions-panel-iframe').within(() => {
cy.findByRole('button', { name: 'Open adjust tags section' }).click({
force: true,
});
cy.findByRole('button', { name: 'Open adjust tags section' }).click();
cy.findByTestId('add-tag-button').click();
cy.findByPlaceholderText('Add a tag').type('tag2');
cy.findByPlaceholderText('Reason to add tag (optional)').type(
@ -145,9 +143,7 @@ describe('Adjust post tags', () => {
.should('not.exist');
cy.getIframeBody('.actions-panel-iframe').within(() => {
cy.findByRole('button', { name: 'Open adjust tags section' }).click({
force: true,
});
cy.findByRole('button', { name: 'Open adjust tags section' }).click();
cy.findByTestId('add-tag-button').click();
cy.findByPlaceholderText('Add a tag').type('tag2');
cy.findByPlaceholderText('Reason to add tag (optional)').type(

13
cypress/e2e/seededFlows/profileFlows/profileUserActionsMenu.spec.js
View file

@ -30,13 +30,11 @@ describe('Profile User Actions Menu', () => {
cy.fixture('users/adminUser.json').as('user');
cy.get('@user').then((user) => {
cy.loginAndVisit(user, '/');
cy.loginAndVisit(user, '/article_editor_v1_user');
});
});
it("should show a dropdown menu when a user views another user's profile", () => {
cy.visit('/article_editor_v1_user');
// Make sure the dropdown has initialized
cy.get('[data-dropdown-initialized]');
@ -73,8 +71,6 @@ describe('Profile User Actions Menu', () => {
// Always accept the confirmation that pops up
cy.on('window:confirm', () => true);
cy.visit('/article_editor_v1_user');
// Make sure the dropdown has initialized
cy.get('[data-dropdown-initialized]');
@ -94,9 +90,6 @@ describe('Profile User Actions Menu', () => {
it('should flag and unflag a user', () => {
// Always accept the confirmation that pops up
cy.on('window:confirm', () => true);
cy.visit('/article_editor_v1_user');
// Make sure the dropdown has initialized
cy.get('[data-dropdown-initialized]');
@ -104,8 +97,8 @@ describe('Profile User Actions Menu', () => {
cy.findByRole('link', { name: 'Flag @article_editor_v1_user' }).click();
// Check that the menu option has updated
cy.findByRole('link', { name: 'Flag @article_editor_v1_user' }).should(
'not.exist',
cy.findByRole('link', { name: 'Unflag @article_editor_v1_user' }).should(
'exist',
);
cy.findByRole('link', { name: 'Unflag @article_editor_v1_user' }).click();