From 2400908b9d25c164912a5e77cb377132be2cd358 Mon Sep 17 00:00:00 2001 From: Arun Kumar Date: Thu, 12 Jul 2018 09:58:37 -0500 Subject: [PATCH] Refactor render_rewarding_context_message_html method with a guard (#569) clause --- app/models/badge_achievement.rb | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/models/badge_achievement.rb b/app/models/badge_achievement.rb index f8a6ee48a..4b70c99f8 100644 --- a/app/models/badge_achievement.rb +++ b/app/models/badge_achievement.rb @@ -14,14 +14,14 @@ class BadgeAchievement < ApplicationRecord before_validation :render_rewarding_context_message_html def render_rewarding_context_message_html - if rewarding_context_message_markdown.present? - parsed_markdown = MarkdownParser.new(rewarding_context_message_markdown) - html = parsed_markdown.finalize - final_html = ActionController::Base.helpers.sanitize html, - tags: %w(strong em i b u a code), - attributes: %w(href name) - self.rewarding_context_message = final_html - end + return if rewarding_context_message_markdown.blank? + + parsed_markdown = MarkdownParser.new(rewarding_context_message_markdown) + html = parsed_markdown.finalize + final_html = ActionController::Base.helpers.sanitize html, + tags: %w(strong em i b u a code), + attributes: %w(href name) + self.rewarding_context_message = final_html end def name_of_user