maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix notes typo + correctly add event listener to correct buttons (#20459)

Browse source
This commit is contained in:
Philip How 2023-12-18 15:07:30 +00:00 • committed by GitHub
parent 59ee1461a4
commit 199a88a254
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/admin/feedback_messages_controller.rb
View file

@ -37,7 +37,7 @@ module Admin
def show def show
@feedback_message = FeedbackMessage.find_by(id: params[:id]) @feedback_message = FeedbackMessage.find_by(id: params[:id])
@email_messages = EmailMessage.find_for_reports(@feedback_message.id) @email_messages = EmailMessage.find_for_reports(@feedback_message.id)
@notes = Note.find_for_reports(@feedback_messages) @notes = Note.find_for_reports(@feedback_message)
end end
def send_email def send_email

14
app/views/admin/feedback_messages/_feedback_message.html.erb
View file

@ -97,18 +97,18 @@
<% case feedback_message.status %> <% case feedback_message.status %>
<% when 'Open' %> <% when 'Open' %>
<div class="flex"> <div class="flex">
<%= button_tag "✅ Resolved", type: "button", data: { status: "Resolved", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 mr-2" %> <%= button_tag "✅ Resolved", type: "button", data: { status: "Resolved", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 mr-2 status-button" %>
<%= button_tag "❌ Invalid", type: "button", data: { status: "Invalid", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3" %> <%= button_tag "❌ Invalid", type: "button", data: { status: "Invalid", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 status-button" %>
</div> </div>
<% when 'Invalid' %> <% when 'Invalid' %>
<div class="flex"> <div class="flex">
<%= button_tag "❔ Open", type: "button", data: { status: "Open", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 mr-2" %> <%= button_tag "❔ Open", type: "button", data: { status: "Open", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 mr-2 status-button" %>
<%= button_tag "✅ Resolved", type: "button", data: { status: "Resolved", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3" %> <%= button_tag "✅ Resolved", type: "button", data: { status: "Resolved", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 status-button" %>
</div> </div>
<% when 'Resolved' %> <% when 'Resolved' %>
<div class="flex"> <div class="flex">
<%= button_tag "❔Open", type: "button", data: { status: "Open", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 mr-2" %> <%= button_tag "❔Open", type: "button", data: { status: "Open", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 mr-2 status-button" %>
<%= button_tag "❌ Invalid", type: "button", data: { status: "Invalid", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3" %> <%= button_tag "❌ Invalid", type: "button", data: { status: "Invalid", id: feedback_message.id }, class: "c-btn c-btn--primary block mt-3 status-button" %>
</div> </div>
<% end %> <% end %>
<div class="mt-2 fs-italic hidden" id="update_message__<%= feedback_message.id %>">You have marked this as Resolved</div> <div class="mt-2 fs-italic hidden" id="update_message__<%= feedback_message.id %>">You have marked this as Resolved</div>
@ -286,7 +286,7 @@
} }
document.getElementById('accordion-<%= feedback_message.id %>').addEventListener('click', function(event) { document.getElementById('accordion-<%= feedback_message.id %>').addEventListener('click', function(event) {
if (event.target.classList.contains('c-btn')) { if (event.target.classList.contains('status-button')) {
var status = event.target.dataset.status; var status = event.target.dataset.status;
var id = event.target.dataset.id; var id = event.target.dataset.id;
saveStatus(id, status); saveStatus(id, status);