maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove information route and add a temporary redirect to /about for SEO purposes (#11373)

Browse source 
* chore: remove information route and add redirect

* chore: update messaging

* fix: remove additional path referenced
This commit is contained in:
Ridhwana 2020-11-12 17:02:58 +02:00 • committed by GitHub
parent ab34b37c49
commit 178b0a32f0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 62 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/layouts/_nav_menu.html.erb
View file

@ -15,7 +15,6 @@
<a href="<%= new_path %>" class="crayons-link crayons-link--block">Write a Post</a>
<a href="<%= readinglist_path %>" class="crayons-link crayons-link--block">Reading list</a>
<a href="<%= user_settings_path %>" class="crayons-link crayons-link--block">Settings</a>
<a href="<%= information_path %>" class="crayons-link crayons-link--block" id="second-last-nav-link">Key Links</a>
</div>
<div class="p-1">
<a href="<%= signout_confirm_path %>" class="crayons-link crayons-link--block" id="last-nav-link">Sign Out</a>
@ -43,9 +42,6 @@
<a href="<%= about_path %>" class="crayons-link crayons-link--block" id="last-nav-link">
About <%= community_name %>
</a>
<a href="<%= information_path %>" class="crayons-link crayons-link--block" id="last-nav-link">
Learn more
</a>
</div>
<% end %>
</div>

57
app/views/pages/information.html.erb
View file

@ -1,57 +0,0 @@
<% title "About #{community_qualified_name}" %>
<%= content_for :page_meta do %>
<link rel="canonical" href="<%= app_url("/p/information") %>" />
<meta name="description" content="All information about <%= community_qualified_name %>">
<%= meta_keywords_default %>
<meta property="og:type" content="article" />
<meta property="og:url" content="<%= app_url("/p/information") %>" />
<meta property="og:title" content="All information about <%= community_qualified_name %>" />
<meta property="og:image" content="<%= SiteConfig.main_social_image %>" />
<meta property="og:description" content="<%= community_qualified_name %> is great!" />
<meta property="og:site_name" content="<%= community_qualified_name %>" />
<meta name="twitter:card" content="summary_large_image">
<meta name="twitter:site" content="@<%= SiteConfig.social_media_handles["twitter"] %>">
<meta name="twitter:title" content="All information about <%= community_qualified_name %>">
<meta name="twitter:description" content="<%= community_qualified_name %> is great!">
<meta name="twitter:image:src" content="<%= SiteConfig.main_social_image %>">
<% end %>
<style>
.key-links {
font-family: "Helvetica Neue", Helvetica, Arial, "Lucida Grande", sans-serif;
}
.social-links {
text-align: center;
padding: 40px 0px;
filter: invert(0);
filter: var(--theme-social-icon-invert, invert(0));
}
</style>
<div class="crayons-layout crayons-layout--limited-l">
<div class="crayons-card text-styles text-padding">
<h1 class="fs-3xl s:fs-4xl l:fs-5xl fw-bold s:fw-heavy lh-tight mb-4 mt-0">More information about <%= community_name %> 👋</h1>
<ul>
<li><a href="/">Home</a></li>
<li><a href="/about">About</a></li>
<% if SiteConfig.shop_url.present? %>
<li><a href="<%= SiteConfig.shop_url %>"><%= community_name %> Shop</a></li>
<% end %>
<li><a href="/sponsors">Sponsors</a></li>
<li><a href="/faq">FAQ</a></li>
<li><a href="/privacy">Privacy Policy</a></li>
<li><a href="/terms">Terms of Use</a></li>
<li><a href="/contact">Contact</a></li>
<li><a href="/security">Vulnerabilities/Bug Bounty</a></li>
<li><a href="/code-of-conduct">Code of Conduct</a></li>
<li><a href="/downloads">Get the mobile app</a></li>
</ul>
<%= render partial: "layouts/social_media" %>
</div>
</div>

6
config/routes.rb
View file

@ -427,8 +427,12 @@ Rails.application.routes.draw do
get "/page/:slug" => "pages#show"
# TODO: [forem/teamsmash] removed the /p/information view and added a redirect for SEO purposes.
# We need to remove this route in 2 months (11 January 2021).
get "/p/information", to: redirect("/about")
scope "p" do
pages_actions = %w[welcome editor_guide publishing_from_rss_guide information markdown_basics badges].freeze
pages_actions = %w[welcome editor_guide publishing_from_rss_guide markdown_basics badges].freeze
pages_actions.each do |action|
get action, action: action, controller: "pages"
end