maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove whitespace in element attributes (#15166)

Browse source 
For most of these this isn't a big deal because `class` is delimited
by whitespace, but it changes the meaning of the `id` attribute since it
must be an exact match (including whitespace). There is also a data-*
attribute or two in here that may have had their semantics changed.
This commit is contained in:
Jamie Gaskins 2021-10-22 15:08:17 -04:00 • committed by GitHub
parent cde6f04cc7
commit 10e3fc2af6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
app/views/moderations/actions_panel.html.erb
View file

@ -129,7 +129,7 @@
<h3><%= t("views.moderations.actions.experience.subtitle") %></h3>
</header>
</div>
<div class=" toggle-chevron-container ">
<div class="toggle-chevron-container">
<%= inline_svg_tag("chevron-toggle.svg", aria: true, title: t("views.moderations.actions.toggle")) %>
</div>
</button>
@ -145,10 +145,10 @@
class="level-rating-button <%= " selected" if current_rating_value == rating_level[0] %>"
data-user-id="<%= current_user.id %>"
data-article-id="<%= @moderatable.id %>"
data-group=" experience_level ">
<div class=" level-rating-content ">
<span class=" level-rating-number "><%= rating_level[1] %></span>
<span class=" level-rating-text "><%= t("views.moderations.actions.experience.level.#{rating_name}") %></span>
data-group="experience_level">
<div class="level-rating-content">
<span class="level-rating-number"><%= rating_level[1] %></span>
<span class="level-rating-text"><%= t("views.moderations.actions.experience.level.#{rating_name}") %></span>
</div>
<%= inline_svg_tag("checkmark.svg", aria: true, class: "crayons-icon", title: t("views.moderations.actions.checkmark")) %>
</button>
@ -161,10 +161,10 @@
</div>
<% if current_user.any_admin? && @moderatable.published %>
<div class=" unpublish-article ">
<div class="unpublish-article">
<button
class=" crayons-btn crayons-btn--danger "
id=" unpublish-article-btn "
class="crayons-btn crayons-btn--danger"
id="unpublish-article-btn"
data-article-id="<%= @moderatable.id %>"
data-article-author="<%= @moderatable.username %>"
data-article-slug="<%= @moderatable.slug %>">
@ -174,7 +174,7 @@
<% end %>
</div>
<div class=" bottom-actions ">
<button id=" open-flag-user-modal " type=" button "><%= t("views.moderations.actions.flag") %></button>
<div class="bottom-actions">
<button id="open-flag-user-modal" type="button"><%= t("views.moderations.actions.flag") %></button>
</div>
</div>