Modify signup modal for design/efficiency (#291)

This commit is contained in:
Ben Halpern 2018-05-08 15:44:03 -04:00 committed by GitHub
parent 3e64175170
commit 10c56cbc9e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 25 additions and 124 deletions

View file

@ -30,42 +30,6 @@
}
}
}
.global-signup-modal--inner-b{
font-family: $helvetica;
position:fixed;
top:calc(15% - 33px);
left:calc(15% - 33px);
right:calc(15% - 33px);
bottom:calc(15% - 33px);
background:white;
z-index:899902;
text-align:center;
font-size:calc(2vw + 20px);
box-shadow:0px 0px 100px 20px rgba(0,0,0,0.3);
border-radius:8px;
padding:calc(4vw + 24px) calc(1vw + 10px);
h1{
font-size:1.4em;
font-weight:400;
}
a{
display:inline-block;
margin:calc(3vw + 5px) 10px;
border:1px solid #b5b5b5;
border-radius:8px;
padding: calc(1vw + 4px) calc(3vw + 10px);
img{
width:calc(1.1vw + 23px);
height:calc(1.1vw + 23px);
vertical-align: -3px;
}
}
.heart{
display:block;
margin:auto;
width:40px;
}
}
.global-signup-modal--inner-a{
font-family: $helvetica;
position:fixed;
@ -76,18 +40,17 @@
background:white;
z-index:899902;
text-align:center;
font-size:calc(2vw + 20px);
font-size:calc(0.8vw + 15px);
box-shadow:0px 0px 100px 20px rgba(0,0,0,0.3);
border-radius:8px;
padding:calc(1vw + 24px) calc(1vw + 10px);
h1{
font-size:.8em;
font-weight:600;
margin-top:0px;
margin-bottom:5px;
margin-bottom:18px;
}
p{
font-size: .5em;
font-size: .73em;
max-width: 75%;
text-align: center;
margin:auto;
@ -95,17 +58,19 @@
a{
display:inline-block;
margin:calc(2vw + 5px) 10px;
border:1px solid #b5b5b5;
border-radius:8px;
border-radius:100px;
padding: calc(.5vw + 4px) calc(1.5vw + 10px);
background: $purple;
color: $bold-blue;
img{
width:calc(1.1vw + 23px);
height:calc(1.1vw + 23px);
vertical-align: -3px;
width:calc(1vw + 18px);
height:calc(1vw + 18px);
vertical-align: calc(-0.1em - 2px);
}
}
.sloan{
height: calc(7vw + 80px);
margin-top: calc(6vh - 10px);
}
}
}

View file

@ -1,51 +0,0 @@
csv.headers :id,
:created_at,
:username,
:twitter_username,
:name, :shipping_name,
:shipping_company,
:shipping_address,
:shipping_address_line_2,
:shipping_city,
:shipping_state,
:shipping_postal_code,
:shipping_country,
:shirt_gender,
:shirt_size,
:twitter_created_at,
:github_created_at,
:twitter_following_count,
:twitter_followers_count,
:experience_level,
:top_languages,
:experience_level,
:specialty,
:tabs_or_spaces,
:email
csv.rows @users do |csv, user|
csv.cells :id,
:created_at,
:username,
:twitter_username,
:name, :shipping_name,
:shipping_company,
:shipping_address,
:shipping_address_line_2,
:shipping_city,
:shipping_state,
:shipping_postal_code,
:shipping_country,
:shirt_gender,
:shirt_size,
:twitter_created_at,
:github_created_at,
:twitter_following_count,
:twitter_followers_count,
:experience_level,
:top_languages,
:experience_level,
:specialty,
:tabs_or_spaces,
:email
end

View file

@ -1,9 +1,7 @@
<% if rand(2) == 1 %>
<% version = "07112017-sloth-full-description" %>
<div class="global-signup-modal split-test-tracking-div" id="global-signup-modal" style="display:none" data-version="<%= version %>">
<div class="global-signup-modal" id="global-signup-modal" style="display:none">
<div class="global-signup-modal--bg" id="global-signup-modal-bg">
<button class="close-modal-button">
<%=image_tag("/assets/cancel.svg", class:"search-icon", alt:"close-button")%>
<img src="<%= asset_path("cancel.svg") %>" class="search-img" alt="close-button"/>
</button>
</div>
<div class="global-signup-modal--inner-a">
@ -17,28 +15,16 @@
:sign_url => true), class:"sloan", alt:"sloth-mascot") %>
<h1>Join our DEV Community :)</h1>
<p>
Were a place for programmers to stay up-to-date, learn new skills, and share ideas.
Were a place where coders share, stay up-to-date and grow their careers.
</p>
<a onclick='<%=track_split_version("/users/auth/twitter?state=signup-modal_#{version}",version) %>' href="/users/auth/twitter?state=signup-modal_<%= version %>" class="sign-up-link" data-no-instant><%= image_tag("twitter-logo.svg", class:"icon-img", alt: "twitter logo") %> Twitter</a>
<a onclick='<%=track_split_version("/users/auth/github?state=signup-modal_#{version}",version) %>' href="/users/auth/github?state=signup-modal_<%= version %>" class="sign-up-link" data-no-instant><%= image_tag("github-logo.svg", class:"icon-img", alt: "github logo") %> GitHub</a>
<a href="/users/auth/twitter?state=signup-modal" class="sign-up-link cta" data-no-instant>
<img src="<%= asset_path("twitter-logo.svg") %>" class="icon-img" alt="Twitter"/> Auth With Twitter
</a>
<a href="/users/auth/github?state=signup-modal" class="sign-up-link cta" data-no-instant>
<img src="<%= asset_path("github-logo.svg") %>" class="icon-img" alt="GitHub"/> Auth With GitHub
</a>
<p>
<em>Well never post without your permission.</em>
<em>We strive for transparency and don't collect excess data.</em>
</p>
</div>
</div>
<% else %>
<% version = "07112017-sign-in-first" %>
<div class="global-signup-modal split-test-tracking-div" id="global-signup-modal" style="display:none" data-version="<%= version %>">
<div class="global-signup-modal--bg" id="global-signup-modal-bg">
<button class="close-modal-button">
<%=image_tag("/assets/cancel.svg", class:"search-icon", alt:"close-button")%>
</button>
</div>
<div class="global-signup-modal--inner-b">
<h1>Sign in first 🤓</h1>
<a onclick='<%=track_split_version("/users/auth/twitter?state=signup-modal_#{version}",version) %>' href="/users/auth/twitter?state=signup-modal_<%= version %>" class="sign-up-link" data-no-instant><%= image_tag("twitter-logo.svg", class:"icon-img", alt: "twitter logo") %> Twitter</a>
<a onclick='<%=track_split_version("/users/auth/github?state=signup-modal_#{version}",version) %>' href="/users/auth/github?state=signup-modal_<%= version %>" class="sign-up-link" data-no-instant><%= image_tag("github-logo.svg", class:"icon-img", alt: "github logo") %> GitHub</a>
<img class="heart" src="<%= asset_path("emoji/emoji-one-heart") %>" />
</div>
</div>
<% end %>
</div>

View file

@ -86,8 +86,10 @@
<% end %>
</div>
<% unless is_internal_navigation? %>
<%= render "layouts/footer" %>
<%= render "layouts/signup_modal" unless user_signed_in? %>
<% cache("footer-and-signup-modal--#{user_signed_in?}--#{ENV["DEPLOYMENT_SIGNATURE"].to_s}", :expires_in => 200.hours) do %>
<%= render "layouts/footer" %>
<%= render "layouts/signup_modal" unless user_signed_in? %>
<% end %>
<div id="live-article-indicator" class="live-article-indicator"></div>
<%= image_tag("twitter-logo.svg", class:"icon-img", style:"display:none") %>
<%= image_tag("github-logo.svg", class:"icon-img", style:"display:none") %>

View file

@ -80,7 +80,6 @@ Rails.application.routes.draw do
resources :followed_articles, only: [:index]
resources :follows, only: [:index,:show,:create]
resources :giveaways, only: [:create,:update]
resources :csv_exports, only: [:index]
resources :image_uploads, only: [:create]
resources :blocks
resources :notifications, only: [:index]