diff --git a/app/services/articles/feeds/large_forem_experimental.rb b/app/services/articles/feeds/large_forem_experimental.rb index a4baee456..be14fe4fb 100644 --- a/app/services/articles/feeds/large_forem_experimental.rb +++ b/app/services/articles/feeds/large_forem_experimental.rb @@ -28,11 +28,10 @@ module Articles end def published_articles_by_tag - articles = Article.published.limited_column_select + articles = @tag.present? ? Tag.find_by(name: @tag).articles : Article + articles.published.limited_column_select .includes(top_comments: :user) .page(@page).per(@number_of_articles) - articles = articles.cached_tagged_with(@tag) if @tag.present? # More efficient than tagged_with - articles end # Timeframe values from Timeframe::DATETIMES diff --git a/spec/services/articles/feeds/large_forem_experimental_spec.rb b/spec/services/articles/feeds/large_forem_experimental_spec.rb index 314cf9360..244e3de7d 100644 --- a/spec/services/articles/feeds/large_forem_experimental_spec.rb +++ b/spec/services/articles/feeds/large_forem_experimental_spec.rb @@ -15,7 +15,7 @@ RSpec.describe Articles::Feeds::LargeForemExperimental, type: :service do describe "#published_articles_by_tag" do let(:unpublished_article) { create(:article, published: false) } let(:tag) { "foo" } - let(:tagged_article) { create(:article, tags: tag) } + let!(:tagged_article) { create(:article, tags: tag) } it "returns published articles" do result = feed.published_articles_by_tag