From 0cdbf468282c9df6cb28581f6da9eaf2c3eb9a02 Mon Sep 17 00:00:00 2001 From: Molly Struve Date: Sun, 13 Sep 2020 13:45:14 -0500 Subject: [PATCH] [deploy] Refactor:Remove unused ReadingList Labor methods (#10292) --- app/labor/reading_list.rb | 12 ------------ spec/labor/reading_list_spec.rb | 18 ------------------ 2 files changed, 30 deletions(-) diff --git a/app/labor/reading_list.rb b/app/labor/reading_list.rb index 7669f16a6..a0e3907c7 100644 --- a/app/labor/reading_list.rb +++ b/app/labor/reading_list.rb @@ -5,14 +5,6 @@ class ReadingList @user = user end - def get - Article - .joins(:reactions) - .includes(:user) - .where(reactions: reaction_criteria) - .order("reactions.created_at" => :desc) - end - def cached_ids_of_articles Rails.cache.fetch("reading_list_ids_of_articles_#{user.id}_#{user.public_reactions_count}") do ids_of_articles @@ -23,10 +15,6 @@ class ReadingList Reaction.where(reaction_criteria).where.not(status: "archived").order(created_at: :desc).pluck(:reactable_id) end - def count - get.size - end - def reaction_criteria { user_id: user.id, reactable_type: "Article", category: "readinglist" } end diff --git a/spec/labor/reading_list_spec.rb b/spec/labor/reading_list_spec.rb index 699603c57..cbe5c5e39 100644 --- a/spec/labor/reading_list_spec.rb +++ b/spec/labor/reading_list_spec.rb @@ -15,28 +15,10 @@ RSpec.describe ReadingList, type: :labor do ) end - it "returns count of articles if they've been reacted to" do - create_reaction(user, article) - create_reaction(user, article2) - - expect(described_class.new(user).count).to eq(2) - end - - it "returns an article if it's been reacted to" do - create_reaction(user, article) - create_reaction(user, article2) - - expect(described_class.new(user).get.first.id).to eq(article2.id) - end - it "returns cached ids of articles that have been reacted to" do create_reaction(user, article) create_reaction(user, article2) expect(described_class.new(user).cached_ids_of_articles).to eq([article2.id, article.id]) end - - it "returns an empty count if no reacted article" do - expect(described_class.new(user).count).to eq(0) - end end