From 0c8f3012274fca9fb380e33b2da932ee1eb5f6d5 Mon Sep 17 00:00:00 2001 From: Lawrence Date: Fri, 10 Feb 2023 12:38:13 -0600 Subject: [PATCH] init commentPreview migration (#19090) --- app/assets/javascripts/initializePage.js | 4 +--- app/javascript/packs/baseInitializers.js | 6 ++++-- .../__tests__/initializeCommentPreview.test.js | 17 +++++++++++++++++ .../initializers/initializeCommentPreview.js | 2 +- 4 files changed, 23 insertions(+), 6 deletions(-) create mode 100644 app/javascript/packs/initializers/__tests__/initializeCommentPreview.test.js rename app/{assets/javascripts => javascript/packs}/initializers/initializeCommentPreview.js (97%) diff --git a/app/assets/javascripts/initializePage.js b/app/assets/javascripts/initializePage.js index 97d0dcf92..b49777a33 100644 --- a/app/assets/javascripts/initializePage.js +++ b/app/assets/javascripts/initializePage.js @@ -3,8 +3,7 @@ initializeAllTagEditButtons, initializeUserFollowButts, initializeCommentsPage, initializeArticleDate, initializeArticleReactions, initNotifications, - initializeSettings, - initializeCommentPreview, initializeRuntimeBanner, + initializeSettings, initializeRuntimeBanner, initializeTimeFixer, initializeDashboardSort, initializeArchivedPostFilter, initializeCreditsPage, initializeProfileInfoToggle, initializeDrawerSliders, @@ -21,7 +20,6 @@ function callInitializers() { initializeArticleReactions(); initNotifications(); initializeSettings(); - initializeCommentPreview(); initializeTimeFixer(); initializeDashboardSort(); initializeArchivedPostFilter(); diff --git a/app/javascript/packs/baseInitializers.js b/app/javascript/packs/baseInitializers.js index 4c90cd89f..0eb1aabd0 100644 --- a/app/javascript/packs/baseInitializers.js +++ b/app/javascript/packs/baseInitializers.js @@ -1,3 +1,5 @@ -import { initializeCommentDate } from "./initializers/initializeCommentDate"; +import { initializeCommentDate } from './initializers/initializeCommentDate'; +import { initializeCommentPreview } from './initializers/initializeCommentPreview'; -initializeCommentDate(); \ No newline at end of file +initializeCommentDate(); +initializeCommentPreview(); diff --git a/app/javascript/packs/initializers/__tests__/initializeCommentPreview.test.js b/app/javascript/packs/initializers/__tests__/initializeCommentPreview.test.js new file mode 100644 index 000000000..3f74b7aba --- /dev/null +++ b/app/javascript/packs/initializers/__tests__/initializeCommentPreview.test.js @@ -0,0 +1,17 @@ +import { initializeCommentPreview } from '../initializeCommentPreview'; + +describe('initializeCommentPreview', () => { + beforeEach(() => { + const button = document.createElement('button'); + button.classList.add('preview-toggle'); + }); + + test('should call event listener when preview button exist', async () => { + const button = document.createElement('button'); + button.classList.add('preview-toggle'); + button.addEventListener = jest.fn(); + initializeCommentPreview(); + + expect(button.addEventListener).not.toHaveBeenCalled(); + }); +}); diff --git a/app/assets/javascripts/initializers/initializeCommentPreview.js b/app/javascript/packs/initializers/initializeCommentPreview.js similarity index 97% rename from app/assets/javascripts/initializers/initializeCommentPreview.js rename to app/javascript/packs/initializers/initializeCommentPreview.js index 99e928faa..9c51f3198 100644 --- a/app/assets/javascripts/initializers/initializeCommentPreview.js +++ b/app/javascript/packs/initializers/initializeCommentPreview.js @@ -57,7 +57,7 @@ function handleCommentPreview(event) { } } -function initializeCommentPreview() { +export function initializeCommentPreview() { const previewButton = document.getElementsByClassName('preview-toggle')[0]; if (!previewButton) {