maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use honeybadger.js from npm (#5643)

Browse source 
rails-assets.org is often down, and apparently has been down intermittently since yesterday.

In addition to this the only thing the gem does is literally to add `honeybadger.js` to the assets path:

```ruby
gem_path.join('app/assets').each_child.to_a
```

Hence we can ditch the gem and use the library directly.
This commit is contained in:
rhymes 2020-01-22 14:22:51 +01:00 • committed by Molly Struve
parent 5b35370db8
commit 09cf6719eb
6 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Gemfile
View file

@ -103,10 +103,6 @@ gem "ulid", "~> 1.1" # Universally Unique Lexicographically Sortable Identifier
gem "validate_url", "~> 1.0" # Library for validating urls in Rails
gem "webpacker", "~> 3.5" # Use webpack to manage app-like JavaScript modules in Rails
source "https://rails-assets.org" do
gem "rails-assets-honeybadger"
end
group :development do
gem "better_errors", "~> 2.5" # Provides a better error page for Rails and other Rack apps
gem "binding_of_caller", "~> 0.8" # Retrieve the binding of a method's caller

3
Gemfile.lock
View file

@ -16,7 +16,6 @@ GIT
GEM
remote: https://rubygems.org/
remote: https://rails-assets.org/
specs:
actioncable (5.2.4.1)
actionpack (= 5.2.4.1)
@ -587,7 +586,6 @@ GEM
bundler (>= 1.3.0)
railties (= 5.2.4.1)
sprockets-rails (>= 2.0.0)
rails-assets-honeybadger (5.0.0)
rails-dom-testing (2.0.3)
activesupport (>= 4.2.0)
nokogiri (>= 1.6)
@ -961,7 +959,6 @@ DEPENDENCIES
rack-host-redirect (~> 1.3)
rack-timeout (~> 0.6)
rails (~> 5.2)
rails-assets-honeybadger!
rails-observers (~> 0.1)
rails-settings-cached (>= 2.1.1)
ransack (~> 2.3)

2
app/assets/javascripts/base.js.erb
View file

@ -3,7 +3,7 @@
//= require lib/xss
//= require initializePage
//= require utilities/getImageForLink
//= require honeybadger
//= require honeybadger-js/dist/honeybadger.js
//= require serviceworker-companion
//= require algolia/v3/algoliasearch.min

3
config/initializers/assets.rb
View file

@ -6,7 +6,7 @@ Rails.application.config.assets.version = "1.1"
# Add additional assets to the asset load path
# Rails.application.config.assets.paths << Emoji.images_path
# Yarn node_moduless
# Yarn node_modules
Rails.application.config.assets.paths << Rails.root.join("node_modules")
# Precompile additional assets.
@ -33,3 +33,4 @@ Rails.application.config.assets.precompile += %w[lib/pulltorefresh.js]
Rails.application.config.assets.precompile += %w[internal.js]
Rails.application.config.assets.precompile += %w[internal/layout]
Rails.application.config.assets.precompile << /\.(?:svg|eot|woff|ttf)\z/
Rails.application.config.assets.precompile += %w[honeybadger-js/dist/honeybadger.js]

1
package.json
View file

@ -94,6 +94,7 @@
"clipboard-polyfill": "^2.8.6",
"codemirror": "^5.50.2",
"focus-visible": "^5.0.2",
"honeybadger-js": "2.0.2",
"intersection-observer": "^0.7.0",
"linkstate": "^1.1.1",
"lodash.debounce": "4.0.8",

5
yarn.lock
View file

@ -5837,6 +5837,11 @@ homedir-polyfill@^1.0.1:
dependencies:
parse-passwd "^1.0.0"
honeybadger-js@2.0.2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/honeybadger-js/-/honeybadger-js-2.0.2.tgz#191f4c0fc2b280b9591bd033e165707e9c7264f6"
integrity sha512-XBzVxiA0Kw91Lh6lM9IXp++IaBt26BwEgmItUhn8Cb8kOWrYeR9h0tAHgvSsB+PS02G7e6IszgpIrMeU69X8ww==
hosted-git-info@^2.1.4:
version "2.7.1"
resolved "https://registry.yarnpkg.com/hosted-git-info/-/hosted-git-info-2.7.1.tgz#97f236977bd6e125408930ff6de3eec6281ec047"