From 08c070b7e31ee01c897df22ebaebafe6fae88f1e Mon Sep 17 00:00:00 2001
From: Arun Kumar <arunmohandm@gmail.com>
Date: Thu, 3 Jan 2019 16:45:28 -0500
Subject: [PATCH] Fix block delimiters Rubocop offense (#1456)

---
 .rubocop_todo.yml                        | 12 ------------
 spec/requests/articles_api_spec.rb       | 14 +++++++++-----
 spec/requests/internal_reactions_spec.rb |  6 ++++--
 3 files changed, 13 insertions(+), 19 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 0a24f12a1..e3613c3b4 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -27,18 +27,6 @@ RSpec/FilePath:
 RSpec/MultipleExpectations:
   Max: 6
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# IgnoredMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'spec/requests/articles_api_spec.rb'
-    - 'spec/requests/internal_reactions_spec.rb'
-
 # Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
diff --git a/spec/requests/articles_api_spec.rb b/spec/requests/articles_api_spec.rb
index bd1abe57e..fb4eab97d 100644
--- a/spec/requests/articles_api_spec.rb
+++ b/spec/requests/articles_api_spec.rb
@@ -131,13 +131,17 @@ RSpec.describe "ArticlesApi", type: :request do
     end
 
     it "does not allow user to update a different article" do
-      new_title = "NEW TITLE #{rand(100)}"
       article.update_column(:user_id, user2.id)
 
-      expect {
-        put "/api/articles/#{article.id}",
-          params: { article: { title: new_title, body_markdown: "Yo ho ho#{rand(100)}", tag_list: "yo" } }
-      } .to raise_error(ActionController::RoutingError)
+      invalid_update_request = -> do
+        put "/api/articles/#{article.id}", params: {
+          article: { title: "NEW TITLE #{rand(100)}",
+                     body_markdown: "Yo ho ho#{rand(100)}",
+                     tag_list: "yo" }
+        }
+      end
+
+      expect(invalid_update_request).to raise_error(ActionController::RoutingError)
     end
 
     it "does allow super user to update a different article" do
diff --git a/spec/requests/internal_reactions_spec.rb b/spec/requests/internal_reactions_spec.rb
index 3824dfbe8..f8e0415a5 100644
--- a/spec/requests/internal_reactions_spec.rb
+++ b/spec/requests/internal_reactions_spec.rb
@@ -37,11 +37,13 @@ RSpec.describe "/internal/reactions", type: :request do
     let(:reaction) { create(:reaction, category: "vomit", user_id: user.id, reactable_id: article.id) }
 
     it "updates reaction to be confirmed" do
-      expect {
+      invalid_request = -> do
         put "/internal/reactions/#{reaction.id}", params: {
           reaction: { status: "confirmed" }
         }
-      }.to raise_error(Pundit::NotAuthorizedError)
+      end
+
+      expect(invalid_request).to raise_error(Pundit::NotAuthorizedError)
     end
   end
 end