diff --git a/app/javascript/.eslintrc.js b/app/javascript/.eslintrc.js index c0b8e4720..6426df9d4 100644 --- a/app/javascript/.eslintrc.js +++ b/app/javascript/.eslintrc.js @@ -43,6 +43,7 @@ module.exports = { }, plugins: ['import', 'react', 'jsx-a11y'], rules: { + 'no-var': 'error', 'import/order': ['error'], 'import/prefer-default-export': 'off', 'no-unused-vars': ['error', { argsIgnorePattern: '^_' }], diff --git a/app/javascript/articles/components/CommentsList.jsx b/app/javascript/articles/components/CommentsList.jsx index 457141778..8aad28b59 100644 --- a/app/javascript/articles/components/CommentsList.jsx +++ b/app/javascript/articles/components/CommentsList.jsx @@ -36,7 +36,7 @@ export const CommentsList = ({ comments = [], articlePath, totalCount }) => { return (
{comments.slice(0, numberOfCommentsToShow).map((comment) => { - return ; + return ; })} {moreCommentsButton(comments, articlePath, totalCount)} diff --git a/app/javascript/listings/components/Categories.jsx b/app/javascript/listings/components/Categories.jsx index a25f776bb..606b36a6b 100644 --- a/app/javascript/listings/components/Categories.jsx +++ b/app/javascript/listings/components/Categories.jsx @@ -13,7 +13,11 @@ export class Categories extends Component { ); } - return ; + return ( + + ); }); }; @@ -25,7 +29,7 @@ export class Categories extends Component { {category.name}: {category.rules} ); - return
    {paragraphText}
; + return
    {paragraphText}
; }); return ( diff --git a/app/javascript/listings/components/CategoryLinks.jsx b/app/javascript/listings/components/CategoryLinks.jsx index ed8828f94..0842f1df1 100644 --- a/app/javascript/listings/components/CategoryLinks.jsx +++ b/app/javascript/listings/components/CategoryLinks.jsx @@ -12,6 +12,7 @@ export const CategoryLinks = ({ categories, onClick, selectedCategory }) => { return ( { return ( + #{tag}{' '} )); diff --git a/app/javascript/onboarding/components/FollowUsers.jsx b/app/javascript/onboarding/components/FollowUsers.jsx index c12f1098b..67c586286 100644 --- a/app/javascript/onboarding/components/FollowUsers.jsx +++ b/app/javascript/onboarding/components/FollowUsers.jsx @@ -180,6 +180,7 @@ export class FollowUsers extends Component { return (
( {episodes.map((episode) => ( - + ))} ); diff --git a/app/javascript/utilities/color/WCAGColorContrast.js b/app/javascript/utilities/color/WCAGColorContrast.js index 01b69a1fb..05df1d324 100644 --- a/app/javascript/utilities/color/WCAGColorContrast.js +++ b/app/javascript/utilities/color/WCAGColorContrast.js @@ -12,13 +12,16 @@ export const WCAGColorContrast = { * @return {Number} */ ratio(rgb1, rgb2) { + let sRGB1; + let sRGB2; + if (this.validRGB(rgb1)) { - var sRGB1 = this.RGBtosRGB(rgb1); + sRGB1 = this.RGBtosRGB(rgb1); } else { throw `Invalid color ${rgb1}`; } if (this.validRGB(rgb2)) { - var sRGB2 = this.RGBtosRGB(rgb2); + sRGB2 = this.RGBtosRGB(rgb2); } else { throw `Invalid color ${rgb2}`; } diff --git a/package.json b/package.json index 2829e1640..714d88e83 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "build-storybook": "build-storybook -c app/javascript/.storybook -s app/assets -o app/javascript/storybook-static --quiet && yarn generate-storybook-themes", "prestorybook": "rm -rf app/javascript/storybook-static && yarn generate-storybook-themes", "storybook": "start-storybook -p 6006 -c app/javascript/.storybook -s app/assets,app/javascript/storybook-static", - "lint:frontend": "eslint app/assets/javascripts/**/*.js app/javascript/**/*.jsx app/javascript/**/*.js cypress/**/*.js", + "lint:frontend": "eslint 'app/assets/javascripts/**/*.js' 'app/javascript/**/*.jsx' 'app/javascript/**/*.js' 'cypress/**/*.js'", "test": "jest app/javascript/ bin/ --coverage", "test:watch": "jest app/javascript/ bin/ --watch", "postcss": "postcss public/assets/*.css -d public/assets 2> postcss_error.log",