maverick/docbrown
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve consistency in display ads text styles (#18631)

Browse source 
* Improve consistency in display ads text styles

* Add missing display ad location
This commit is contained in:
Fernando Valverde 2022-10-26 13:56:17 -06:00 • committed by GitHub
parent 3f9b7c073c
commit 0303c1d636
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/admin/display_ads/_form.html.erb
View file

@ -59,7 +59,7 @@
</div>
</div>
<div>
<div class="crayons-card crayons-card--secondary p-4 crayons-sponsorship-widget">
<div class="crayons-card crayons-card--secondary p-4 crayons-sponsorship-widget text-styles">
<% if @display_ad.persisted? %>
<%= @display_ad.processed_html.html_safe %>
<% else %>

2
app/views/articles/show.html.erb
View file

@ -193,7 +193,7 @@
<% cache("article-bottom-content-#{@article.id}-#{user_signed_in?}-#{(@organization || @user).latest_article_updated_at}", expires_in: 18.hours) do %>
<% @display_ad = DisplayAd.for_display("post_comments", user_signed_in?) %>
<% if @display_ad %>
<div class="crayons-card crayons-card--secondary p-4 crayons-sponsorship-article"
<div class="crayons-card crayons-card--secondary p-4 crayons-sponsorship-article text-styles"
data-display-unit data-id="<%= @display_ad.id %>"
data-category-click="<%= DisplayAdEvent::CATEGORY_CLICK %>"
data-category-impression="<%= DisplayAdEvent::CATEGORY_IMPRESSION %>"

2
app/views/sidebars/_homepage_content.html.erb
View file

@ -2,7 +2,7 @@
<% cache(release_adjusted_cache_key("main-article-right-sidebar-discussions-#{params[:timeframe]}-#{user_signed_in?}"), expires_in: (params[:timeframe].blank? ? 120 : 360).seconds) do %>
<% @sidebar_ad = DisplayAd.for_display("sidebar_right", user_signed_in?) %>
<% if @sidebar_ad %>
<div class="crayons-card crayons-card--secondary p-4 crayons-sponsorship-widget" data-display-unit data-id="<%= @sidebar_ad.id %>">
<div class="crayons-card crayons-card--secondary p-4 crayons-sponsorship-widget text-styles" data-display-unit data-id="<%= @sidebar_ad.id %>">
<%= @sidebar_ad.processed_html.html_safe %>
</div>
<% end %>