From 00c5af783e175a230f7fd9b74292ea5e7ac8d71f Mon Sep 17 00:00:00 2001
From: Monica Mateiu <monica.mateiu@gmail.com>
Date: Tue, 28 Sep 2021 15:18:35 +0100
Subject: [PATCH] Include search term in title for improved accessibility
 (#14805)

* Include search term in title for improved accessibility

* Update index.html.erb

* update examples with correct description

Co-authored-by: Michael Kohl <citizen428@forem.com>
---
 app/views/stories/articles_search/index.html.erb |  4 +++-
 spec/requests/stories/articles_search_spec.rb    | 14 ++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/app/views/stories/articles_search/index.html.erb b/app/views/stories/articles_search/index.html.erb
index ddeafa678..16b17ca39 100644
--- a/app/views/stories/articles_search/index.html.erb
+++ b/app/views/stories/articles_search/index.html.erb
@@ -19,7 +19,9 @@
     </div>
 
     <div class="block s:flex items-center justify-between">
-      <h1 class="crayons-title hidden s:block pl-2">Search results</h1>
+      <h1 class="crayons-title hidden s:block pl-2">
+        Search results <%= "for #{params[:q]}" unless params[:q].empty? %>
+      </h1>
 
       <nav id="sorting-option-tabs" aria-label="Search result sort options" class="-mx-3 m:mx-0">
         <ul class="crayons-navigation crayons-navigation--horizontal">
diff --git a/spec/requests/stories/articles_search_spec.rb b/spec/requests/stories/articles_search_spec.rb
index c3f03d6b4..abb8cc656 100644
--- a/spec/requests/stories/articles_search_spec.rb
+++ b/spec/requests/stories/articles_search_spec.rb
@@ -6,5 +6,19 @@ RSpec.describe "Stories::ArticlesSearchController", type: :request do
       get "/search?q=hello"
       expect(response.body).to include("=> Search Results")
     end
+
+    context "with non-empty query" do
+      it "renders search term in page title" do
+        get "/search?q=hello"
+        expect(response.body).to include("Search results for hello")
+      end
+    end
+
+    context "with empty query" do
+      it "renders default page title" do
+        get "/search?q="
+        expect(response.body).to include("Search results\s")
+      end
+    end
   end
 end